fix(tempo): normalize sponsored charge signing#616
Draft
decofe wants to merge 1 commit into
Draft
Conversation
commit: |
decofe
force-pushed
the
centaur/fix-viem-254-fee-payer-1783073960
branch
from
c044b4e to
b3a51fe
Compare
decofe
force-pushed
the
centaur/fix-viem-254-fee-payer-1783073960
branch
from
b3a51fe to
5697fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize sponsored Tempo charge transactions before signing by dropping filled fee-payer fields and then setting
feePayer: true. This keeps client pull-mode charges on the partial fee-payer handoff path expected by servers after viem fee-payer fill behavior changed.The regression was exposed after wevm/viem#4773 landed in
viem@2.54.0, which tightened transaction signature parsing.Testing
VITE_TEMPO_NETWORK=none pnpm exec vp test --project node --run src/tempo/client/Charge.test.tspnpm exec vp fmt --check src/tempo/client/Charge.ts src/tempo/client/Charge.test.tspnpm exec vp lint src/tempo/client/Charge.ts src/tempo/client/Charge.test.tspnpm check:typesPrompted by: @grandizzy