Fix ch3 dependency vulnerabilities with npm overrides#37
Open
ldthorson90 wants to merge 7 commits into
Open
Conversation
npm audit fix --force on all chapter directories. Resolves critical RCE in ejs/handlebars/morgan and high-severity DoS in body-parser/ws/method-override. chapter3 has 4 remaining vulns that require manual dep replacement (ejs/handlebars are direct dependencies with no safe upgrade path). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix critical dependency vulnerabilities
Adds overrides for form-data, qs, and tough-cookie to resolve 3 of 4 remaining vulnerabilities. The last one (request SSRF) requires replacing the deprecated request library entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
form-data,qs, andtough-cookieto resolve 3 of 4 remaining vulnerabilities in chapter3-node-jsrequestpackage to latest v2 release (2.88.2)Remaining
requestpackage (no fix available without replacing the library entirely)Test plan
npm auditin chapter3-node-js shows only 1 remaining vulnerability🤖 Generated with Claude Code