-
Notifications
You must be signed in to change notification settings - Fork 70
chore(meetings): migrate meetings e2e tests to playwright #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from 5 commits
28fc765
32ae068
570e80d
5fb20e3
2a79a00
0204d60
08a1d14
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,4 @@ WEBEX_TEST_SAFARI= | |
| SAUCE_USERNAME= | ||
| SAUCE_ACCESS_KEY= | ||
| SAUCE_REGION=us | ||
| DOTENV_CONFIG_QUIET=true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -182,6 +182,8 @@ jobs: | |
|
|
||
| e2e_test_meetings: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| DOTENV_CONFIG_QUIET: true | ||
| continue-on-error: true | ||
| needs: [install, build] | ||
| if: contains(toJson(github.event.pull_request.labels), 'run_e2e') | ||
|
|
@@ -215,13 +217,18 @@ jobs: | |
| path: '**/dist' | ||
| key: dist-${{ env.rid }} | ||
|
|
||
| - name: Install Playwright Browsers | ||
| run: npx playwright install --with-deps | ||
|
|
||
| - name: Test E2E | ||
| run: yarn workspace @webex/widgets run test:e2e | ||
|
|
||
| e2e_test_cc_widgets: | ||
| timeout-minutes: 50 | ||
| runs-on: ubuntu-latest | ||
| needs: [install, build] | ||
| env: | ||
| DOTENV_CONFIG_QUIET: true | ||
| \ needs: [install, build] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In the pull-request workflow, this leading backslash makes the YAML invalid before GitHub Actions can schedule any jobs; parsing this file now fails at the Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed |
||
| if: contains(toJson(github.event.pull_request.labels), 'run_e2e') | ||
| concurrency: | ||
| group: e2e-cc-widgets | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latest versions of dotenv, have promotions added in logs, so to remove those logs, this flag is set