Skip to content

feat(internal-plugin-encryption): add awsKmsCmkExternalId and awsKmsCiscoRoleArn to CMK response - #5161

Open
maxwellalexgordon wants to merge 2 commits into
webex:nextfrom
maxwellalexgordon:maxwellalexgordon-patch-1
Open

feat(internal-plugin-encryption): add awsKmsCmkExternalId and awsKmsCiscoRoleArn to CMK response#5161
maxwellalexgordon wants to merge 2 commits into
webex:nextfrom
maxwellalexgordon:maxwellalexgordon-patch-1

Conversation

@maxwellalexgordon

@maxwellalexgordon maxwellalexgordon commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

COMPLETES SPARK-843716

This pull request addresses

The KMS SDK has added two new fields (awsKmsCmkExternalId and awsKmsCiscoRoleArn) to the CustomerMainKey response object. The JS SDK's CMK typedef needs to be updated to document these new fields so consumers are aware they exist in the retrieve response.

by making the following changes

  • Added awsKmsCmkExternalId (string | undefined) to the CMK typedef in packages/@webex/internal-plugin-encryption/src/kms.js
  • Added awsKmsCiscoRoleArn (string | undefined) to the CMK typedef

No logic changes are required — these are response-only fields. The existing methods (listAllCustomerMasterKey, changeCustomerMasterKeyState) already return res directly, so the new fields pass through to consumers automatically.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • Verified typedef-only change — no runtime behavior is affected
  • Confirmed listAllCustomerMasterKey and changeCustomerMasterKeyState pass response through unchanged
  • Existing unit tests still pass (no logic modified)

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Windsurf Cascade
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@maxwellalexgordon
maxwellalexgordon requested a review from a team as a code owner August 11, 2026 15:57
@maxwellalexgordon maxwellalexgordon changed the title Update kms.js Update kms.js SPARK-843716 Aug 11, 2026
@maxwellalexgordon maxwellalexgordon changed the title Update kms.js SPARK-843716 feat(internal-plugin-encryption): add awsKmsCmkExternalId and awsKmsCiscoRoleArn to CMK response Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants