feat(plugin-meetings): report new WASM runtime metrics - #5159
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2cd24132c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "@webex/plugin-rooms": "workspace:*", | ||
| "@webex/ts-sdp": "^1.8.1", | ||
| "@webex/web-capabilities": "^1.12.0", | ||
| "@webex/web-capabilities": "link:../../../../web-capabilities", |
There was a problem hiding this comment.
Replace the local web-capabilities link
With this dependency set to link:../../../../web-capabilities, a normal checkout does not contain the target (from packages/@webex/plugin-meetings it resolves outside this repo to a sibling web-capabilities; a repo-wide search found no such package). In clean CI or for published consumers without that sibling checkout, the meeting plugin either gets a dangling module link or falls back to an older transitive copy, so the new WasmRuntimeProbe API used by this commit is not reliably available. Please depend on a published version or add it as a real workspace before merging.
Useful? React with 👍 / 👎.
COMPLETES # SPARK-844160
This pull request addresses
The SDK currently reports
ratio,wasmMs, andjsMsof WASM runtime fields. These fields do not expose the status, capability decision, failure reason, or detailed benchmark measurements from the updated WASM runtime probe that we need now to test metrics results better.by making the following changes
WasmRuntimeProberesultstatus,capability, andreasonChange Type
Risk and downstream impact
The SDK public API is unchanged. Consumers of the
js_sdk_wasm_runtime_performancetelemetry event must use the new fields instead ofratio,wasmMs, andjsMs.A new version of
@webex/web-capabilitieswill contain the updated probe API but for now PR is with local linking version.The following scenarios were tested
yarn workspace @webex/plugin-meetings test:unit --targets meetings/index.jsyarn workspace @webex/plugin-meetings test:style— passingyarn workspace @webex/plugin-meetings build:src— passingTesting screenshot from test app
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that