Skip to content

feat(plugin-meetings): report new WASM runtime metrics - #5159

Open
antsukanova wants to merge 1 commit into
webex:nextfrom
antsukanova:antsukan/wasm-new-prop
Open

feat(plugin-meetings): report new WASM runtime metrics#5159
antsukanova wants to merge 1 commit into
webex:nextfrom
antsukanova:antsukan/wasm-new-prop

Conversation

@antsukanova

Copy link
Copy Markdown
Contributor

COMPLETES # SPARK-844160

This pull request addresses

The SDK currently reports ratio, wasmMs, and jsMs of WASM runtime fields. These fields do not expose the status, capability decision, failure reason, or detailed benchmark measurements from the updated WASM runtime probe that we need now to test metrics results better.

by making the following changes

  • Consume the updated WasmRuntimeProbe result
  • Report status, capability, and reason
  • Report null measurement values when the probe produces no measurements
  • Update diagnostic logging with the new probe result
  • Preserve once-only reporting and prevent probe failures from affecting meeting creation
  • Add coverage for measured and unmeasured probe results

Change Type

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Tooling change
  • Internal code refactor

Risk and downstream impact

The SDK public API is unchanged. Consumers of the js_sdk_wasm_runtime_performance telemetry event must use the new fields instead of ratio, wasmMs, and jsMs.

A new version of @webex/web-capabilities will contain the updated probe API but for now PR is with local linking version.

The following scenarios were tested

  • Verified telemetry containing completed benchmark measurements
  • Verified unknown results include the reason and null measurement fields
  • Verified telemetry is emitted only once
  • Verified probe failures do not prevent meeting creation
  • Verified existing meetings do not rerun the probe
  • yarn workspace @webex/plugin-meetings test:unit --targets meetings/index.js
  • yarn workspace @webex/plugin-meetings test:style — passing
  • yarn workspace @webex/plugin-meetings build:src — passing

Testing screenshot from test app

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI
  • Tool used for AI assistance
    • Github Copilot
    • Other — Cursor
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

Screenshot 2026-08-10 at 13 16 09 Screenshot 2026-08-10 at 13 13 45
  • I have read and followed the contributing guidelines
  • I discussed changes with code owners before submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

@antsukanova
antsukanova requested review from a team as code owners August 10, 2026 12:59
@antsukanova antsukanova self-assigned this Aug 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2cd24132c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"@webex/plugin-rooms": "workspace:*",
"@webex/ts-sdp": "^1.8.1",
"@webex/web-capabilities": "^1.12.0",
"@webex/web-capabilities": "link:../../../../web-capabilities",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace the local web-capabilities link

With this dependency set to link:../../../../web-capabilities, a normal checkout does not contain the target (from packages/@webex/plugin-meetings it resolves outside this repo to a sibling web-capabilities; a repo-wide search found no such package). In clean CI or for published consumers without that sibling checkout, the meeting plugin either gets a dangling module link or falls back to an older transitive copy, so the new WasmRuntimeProbe API used by this commit is not reliably available. Please depend on a published version or add it as a real workspace before merging.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant