fix: bump internal-media-core to 2.29.0 - #5151
Open
SomeBody16 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES SPARK-833463
This pull request addresses
Keeping SDK media dependencies aligned with the latest
@webex/internal-media-corerelease so meetings, calling, and media helpers pick up upstream media diagnostics and stats improvements.by making the following changes
Dependency updates
@webex/internal-media-core2.28.22.29.0media-helpers,plugin-meetings,calling@webex/web-client-media-engine(transitive)3.42.13.43.0yarn.lockNo SDK source code changes — this PR only bumps dependency versions and refreshes the lockfile.
What's new upstream (2.28.2 → 2.29.0)
1. Remote audio first-frame delay detection (
internal-media-core)StatsMonitornow detects when inbound remote audio takes too long to produce its first decoded frame after media monitoring starts.REMOTE_AUDIO_FIRST_FRAME_DELAY_THRESHOLD_MS(5000 ms)InboundAudioIssueSubTypes.REMOTE_AUDIO_FIRST_FRAME_DELAYStatsMonitor.start()/StatsMonitor.stop()lifecycle hooks to anchor the measurement windowfirstAudioFrameTimestampis seen (or delay exceeds threshold), emits an inbound audio issue eventSDK impact: meetings and calling that use
StatsAnalyzer/StatsMonitorcan now surface this via the existingMEDIA_INBOUND_AUDIO_ISSUE_DETECTEDevent (media:inboundAudio:issueDetected).media-helpersre-exports the newInboundAudioIssueSubTypesvalue.2. Inbound RTP stats enrichment (
web-client-media-engine3.43.0)WCME now maps
receivedAudioFrameCountfrom encoded stream metadata into inbound RTP stats. This letsStatsMonitortell whether the encoded audio transform path is active before evaluating first-frame delay.SDK impact: improved media quality diagnostics without API changes in the SDK itself.
Affected SDK packages
@webex/media-helpers— inherits updated WCME/media-core types and re-exports@webex/plugin-meetings— meeting media connections and stats analyzer behavior@webex/calling— calling media stackChange Type
The following scenarios were tested
yarn installcompletes successfully with updated lockfileyarn workspace @webex/media-helpers test:unityarn workspace @webex/plugin-meetings test:unityarn workspace @webex/calling test:unitThe GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.