-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add isCapableOfReceivingVideoCodec
#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5452bbe
feat: add CodecInfo class with methods to check codec availability
fnowakow dd62539
refactor: remove CodecInfo class and related tests
fnowakow 4a5b1bb
refactor: update WebCapabilities methods for codec support checks
fnowakow 01dd296
chore(web-capabilities): add the correct mimeType type
ae2d3c5
test(web-capabilities): add test for undefined return
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { CodecInfo } from './codec-info'; | ||
|
|
||
| describe('CodecInfo', () => { | ||
| describe('isH264Available', () => { | ||
| it('should return true when the H.264 codec is available', async () => { | ||
| expect.assertions(1); | ||
|
|
||
| Object.defineProperty(window, 'RTCPeerConnection', { | ||
| writable: true, | ||
| value: jest.fn().mockReturnValue({ | ||
| createOffer: jest.fn().mockResolvedValue({ | ||
| sdp: 'a=rtpmap:124 H264/90000', | ||
| }), | ||
| close: jest.fn(), | ||
| } as unknown as RTCPeerConnection), | ||
| }); | ||
|
|
||
| await expect(CodecInfo.isH264Available()).resolves.toBe(true); | ||
| }); | ||
|
|
||
| it('should return false when the H.264 codec is not available', async () => { | ||
| expect.assertions(1); | ||
|
|
||
| Object.defineProperty(window, 'RTCPeerConnection', { | ||
| writable: true, | ||
| value: jest.fn().mockReturnValue({ | ||
| createOffer: jest.fn().mockResolvedValue({ | ||
| sdp: 'a=rtpmap:36 rtx/90000', | ||
| }), | ||
| close: jest.fn(), | ||
| } as unknown as RTCPeerConnection), | ||
| }); | ||
|
|
||
| await expect(CodecInfo.isH264Available()).resolves.toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('isAV1Available', () => { | ||
| it('should return true when the AV1 codec is available', async () => { | ||
| expect.assertions(1); | ||
|
|
||
| Object.defineProperty(window, 'RTCPeerConnection', { | ||
| writable: true, | ||
| value: jest.fn().mockReturnValue({ | ||
| createOffer: jest.fn().mockResolvedValue({ | ||
| sdp: 'a=rtpmap:124 AV1/90000', | ||
| }), | ||
| close: jest.fn(), | ||
| } as unknown as RTCPeerConnection), | ||
| }); | ||
|
|
||
| await expect(CodecInfo.isAV1Available()).resolves.toBe(true); | ||
| }); | ||
|
|
||
| it('should return false when the AV1 codec is not available', async () => { | ||
| expect.assertions(1); | ||
|
|
||
| Object.defineProperty(window, 'RTCPeerConnection', { | ||
| writable: true, | ||
| value: jest.fn().mockReturnValue({ | ||
| createOffer: jest.fn().mockResolvedValue({ | ||
| sdp: 'a=rtpmap:36 rtx/90000', | ||
| }), | ||
| close: jest.fn(), | ||
| } as unknown as RTCPeerConnection), | ||
| }); | ||
|
|
||
| await expect(CodecInfo.isAV1Available()).resolves.toBe(false); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /** | ||
| * CodecInfo class to provide static methods for codec information. | ||
| */ | ||
| export class CodecInfo { | ||
| /** | ||
| * Notifies the user whether or not the H.264 | ||
| * codec is present. | ||
| * @returns -boolean. | ||
| */ | ||
| static async isH264Available(): Promise<boolean> { | ||
| let hasCodec = false; | ||
|
|
||
| try { | ||
| const peerConnection = new window.RTCPeerConnection(); | ||
| const offer = await peerConnection.createOffer({ | ||
| offerToReceiveVideo: true, | ||
| }); | ||
|
|
||
| if (offer?.sdp?.match(/^a=rtpmap:\d+\s+H264\/\d+/m)) { | ||
| hasCodec = true; | ||
| } | ||
| peerConnection.close(); | ||
| } catch (error) { | ||
| return false; | ||
| } | ||
|
|
||
| return hasCodec; | ||
| } | ||
|
|
||
| /** | ||
| * Notifies the user whether or not the H.264 | ||
| * codec is present. | ||
| * @returns -boolean. | ||
| */ | ||
| static async isAV1Available(): Promise<boolean> { | ||
| let hasCodec = false; | ||
|
|
||
| try { | ||
| const peerConnection = new window.RTCPeerConnection(); | ||
| const offer = await peerConnection.createOffer({ | ||
| offerToReceiveVideo: true, | ||
| }); | ||
|
|
||
| if (offer?.sdp?.match(/^a=rtpmap:\d+\s+AV1\/\d+/m)) { | ||
| hasCodec = true; | ||
| } | ||
| peerConnection.close(); | ||
| } catch (error) { | ||
| return false; | ||
| } | ||
|
|
||
| return hasCodec; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| export * from './browser-info'; | ||
| export * from './codec-info'; | ||
| export * from './cpu-info'; | ||
| export * from './system-info'; | ||
| export * from './web-capabilities'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.