Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Bumps the default
azure-keyvault-exporterimage from24.9.1to the latest release26.1.0, and bumps the chart version1.0.12→1.1.0.This supersedes #105 (Renovate), whose
lint, installcheck fails because it only changesappVersion.ct lintrejects that withchart version not ok. Needs a version bump!.Which issue this PR fixes
Special notes for your reviewer
Upstream changes between 24.9.1 and 26.1.0 that users should know about:
--log.debug/--log.devel/--log.json(LOG_DEBUG/LOG_DEVEL/LOG_JSON) were replaced by--log.level,--log.format,--log.source,--log.colorand--log.time. Passing an old flag through custom args now fails at startup withunknown flag; the old env vars are ignored. The chart itself doesn't set any of these, so the templates didn't need changes.Tested locally:
ct lint --config ct.yamlpasses, including the version increment check.helm install --waiton kind withci/env-values.yamlandci/secret-values.yamlpasses; the pod becomes ready withdocker.io/webdevops/azure-keyvault-exporter:26.1.0.Checklist
[azure-metrics-exporter])