Skip to content

Reject strings in ReadableStream.from #59594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattiasBuelens merged 1 commit into from
Jul 13, 2026
Merged

Reject strings in ReadableStream.from #59594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions streams/readable-streams/from.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ const iterableFactories = [
return ['a', 'b'][Symbol.iterator]();
}],

['a string', () => {
// This iterates over the code points of the string.
return 'ab';
}],

['a Set', () => {
return new Set(['a', 'b']);
}],
Expand Down Expand Up @@ -170,6 +165,7 @@ const badIterables = [
['Object.create(null)', Object.create(null)],
['a function', () => 42],
['a symbol', Symbol()],
['a string', 'ab'],
['an object with a non-callable @@iterator method', {
[Symbol.iterator]: 42
}],
Expand Down
Loading