Add support for [AllowResizable] inputs in TextDeEncoder#58636
Draft
daxpedda wants to merge 1 commit intoweb-platform-tests:masterfrom
Draft
Add support for [AllowResizable] inputs in TextDeEncoder#58636daxpedda wants to merge 1 commit intoweb-platform-tests:masterfrom
[AllowResizable] inputs in TextDeEncoder#58636daxpedda wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
daxpedda
commented
Mar 20, 2026
| const destinationFiller = destinationData.filler; | ||
| const encoder = new TextEncoder(); | ||
| const opts = resizable ? { maxByteLength: bufferLength } : undefined; | ||
| const buffer = createBuffer(arrayBufferOrSharedArrayBuffer, bufferLength, opts); |
Author
There was a problem hiding this comment.
Because we always want the max length to be the buffer length, I think this could be better solved on the createBuffer level. Maybe detect if opts is a boolean is an option?
daxpedda
commented
Mar 20, 2026
Comment on lines
-17
to
-30
|
|
||
| test(t => { | ||
| const enc = new TextEncoder(); | ||
|
|
||
| // Fixed-length SABs should not throw | ||
| const sab = createBuffer('SharedArrayBuffer', 16); | ||
| enc.encodeInto("foobar", new Uint8Array(sab)); | ||
|
|
||
| const gsab = createBuffer('SharedArrayBuffer', 16, { maxByteLength: 1024 }); | ||
| // TextEncoder.encodeInto doesn't have [AllowResizable] but has [AllowShared] | ||
| assert_throws_js(TypeError, () => { | ||
| enc.encodeInto("foobar", new Uint8Array(gsab)); | ||
| }); | ||
| }, "APIs with [AllowShared] but without [AllowResizable] throw when passed growable SharedArrayBuffers"); |
Author
There was a problem hiding this comment.
No API exists that fulfills these conditions apart from FileSystemSyncAccessHandle.read/write().
I felt like handling this here would be out of scope.
5 tasks
daxpedda
force-pushed
the
encode-resizable
branch
from
d9ae6e2 to
08bc98f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/encoding#362.