[dom] Add tests for "inner invoke" with EventTarget in a detached iframe#34350
Open
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Open
[dom] Add tests for "inner invoke" with EventTarget in a detached iframe#34350chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Jun 8, 2022
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This adds tests for dispatching events to an EventTarget created in an iframe that gets detached --- both prior to and during event dispatch. The behavior of engines for this case is to not run event listeners after the EventTarget's associated global is detached, which is what we check for in the tests. Spec: https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke PR: whatwg/dom#1085 Bug: 1323391 Change-Id: I57aac7d444d3532ad0940a228452d206b5c1be07
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3691385
branch
from
b4e3e51 to
d8f3c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for dispatching events to an EventTarget created in an
iframe that gets detached --- both prior to and during event dispatch.
The behavior of engines for this case is to not run event listeners
after the EventTarget's associated global is detached, which is what we
check for in the tests.
Spec: https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke
PR: whatwg/dom#1085
Bug: 1323391
Change-Id: I57aac7d444d3532ad0940a228452d206b5c1be07
Reviewed-on: https://chromium-review.googlesource.com/3691385
WPT-Export-Revision: 0e925d9e74f482b782ae8f6bcee3d62a6c560bd7