Clojurescript support for clout - #14
Closed
roman wants to merge 14 commits into
Closed
Conversation
|
Any updates? |
Owner
|
Haha, yes, and by two separate guys named Roman around the same time. Very strange. As with these guys, I'm interested in a good, compojure compatible routing story for CLJS. #13 does look better, as that roman also upgraded ring-mock: Happy to help code review if you're into this in theory. |
Owner
|
Ah, they're by two different people. That makes more sense now. Why do you need to match routes in CLJS? |
|
There may be a better way to do it, but I want to keep all of my cljs code in one big generated file (for caching purposes) and then restrict various callback registrations to certain pages. Sort of like https://github.com/gf3/secretary |
Owner
|
Closing this PR as it's incompatible with Clout 2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello James,
I know this is a project that you haven't code in a while, but I took the liberty to polish it a bit and add Clojurescript support for it. Also I bumped the Clojure version to support both 1.4 and 1.5.
Both the code and the testsuite work in Clojurescript (nodejs, chrome, safari, ff, phantomjs), with a TravisCI configuration. We haven't tested thoroughly the code though, we are planning to use it in the future in some of our projects for routing apps in the front-end (Backbone style).
Let me know what you think.
Cheers.
Roman.-