Skip to content

Bump pagy from 9.3.4 to 43.5.3 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

Bump pagy from 9.3.4 to 43.5.3 #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,10 @@ GEM
racc (~> 1.4)
nokogiri (1.19.2-x86_64-linux-gnu)
racc (~> 1.4)
pagy (9.3.4)
pagy (43.5.3)

@chatgpt-codex-connector chatgpt-codex-connector Bot May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Upgrade Pagy call sites alongside major version bump

This lockfile change jumps from Pagy 9.x to 43.x, but the app still uses legacy Pagy APIs (e.g., pagy(@faqs, items: 12) in app/controllers/faqs_controller.rb and include Pagy::Frontend in app/helpers/application_helper.rb). The upstream 43 upgrade guide describes this as a breaking redesign requiring API migration (including new paginator call forms and option names), so leaving code unchanged here is likely to break pagination at runtime when those controller/helper paths execute.

Useful? React with 👍 / 👎.

json
uri
yaml
Comment on lines +290 to +293

@chatgpt-codex-connector chatgpt-codex-connector Bot May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove deprecated trim extra before adopting Pagy 43

Pagy 43 deprecates the legacy extras model and explicitly marks trim as discontinued in its upgrade guidance, but this commit updates the gem without removing the active require "pagy/extras/trim" in config/initializers/pagy.rb. That leaves initialization depending on a legacy path no longer part of the supported 43 setup, which can cause boot-time failures or unsupported pagination behavior in production.

Useful? React with 👍 / 👎.

parallel (1.27.0)
parser (3.3.9.0)
ast (~> 2.4.1)
Expand Down Expand Up @@ -515,6 +518,7 @@ GEM
websocket-extensions (0.1.5)
xpath (3.2.0)
nokogiri (~> 1.8)
yaml (0.4.0)
zeitwerk (2.7.5)

PLATFORMS
Expand Down
Loading