Conversation
Also: 1. Add `autocomplete` attributes 2. Removed 404 resource link 3. Removed old editors CSS link 4. Added `code` tags 5. Updated the list of errors to use a list instead of 3 paragraphs
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1. removed the jQuery and rewrote using vanilla JavaScript 2. Removed several unused functions 3. simplified the date validity field 4. added a replacement image for the one that was missing 5. removed an unnecessary `alert` role 6. moved explanatory content to the technique 7. removed out of date assistive technology information
1. removed jQuery 2. added CSS 3. removed the `focus` functionality for the error message—there’s no point in having a live region with that present 4. added `autocomplete` attributes 5. removed the empty `h2` element 6. moved the error message inside the form 7. slightly tweaked the content of the error message
1. Remove outdated content 2. Update examples to add `autocomplete` attributes 3. Updated resource links 4. Split the example code into separate `pre` blocks
1. remove jquery 2. add `viewport` 3. update css to use modern positioning 4. add `inert` attribute
fstrr
added
Techniques
1.1.1 Non-text content
Working Examples
and removed
1.1.1 Non-text content
labels
|
Moved this back into "In progress", as this will likely need considerable untangling once #4980 lands (possibly to the point where it might be quicker to just redo the PR as a fresh one) |
|
out of interest, i did try a naive "rebase this against the other branch from #4980" but it ended up with merge conflicts all over the shop... so it may indeed be easier to just do a fresh PR that only touches the jquery stuff and nothing else, cleanly. may have a go at it tomorrow... |
|
Resolved the merge conflicts following #4980 but suggest these need to all be carefully checked again now, by hand, to verify they're still doing what they're supposed to and that the styling hasn't gone wrong in the process either |
|
Reviewed the techniques and verified that the working examples work correctly now. This is good to go, as far as i'm concerned |
2 participants
ARIA18
Updated HTML snippet to use updated working example code
Working example:
viewportinertattributeARIA 19
autocompleteattributescodetagsARIA21
autocompleteattributespreblocksIdentifying Errors In Data Format example
alertrolePreviews: