Make Benefits consistently a top-level section with h2 in source files#3939
Merged
Make Benefits consistently a top-level section with h2 in source files#3939
Conversation
|
kfranqueiro marked as non substantive for IPR from ash-nazg. |
Ilovemesomehim1
approved these changes
Jul 14, 2024
Member
|
can we limit reviews/approvals to w3c member users? tired of these random muppet accounts (that clearly seem to somehow game github for some reason) making BS comments/suggestions. |
Contributor
Yes. Ken just now changed the setting after checking in with Kevin and Mike and me. |
patrickhlauke
approved these changes
Aug 2, 2024
Contributor
Author
|
@mbgower did you have to manually deal with merge conflicts? I am concerned that the changeset I see actually merged may have changed more than this PR originally did... |
Contributor
Author
|
I confirmed breakage in the merge; followed up in #4042. In the future, if you run into merge conflicts in my PRs, please ask me to update them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3924.
Also addresses the Label in Name instance in #3922.
The diff will be much easier to compare with whitespace ignored (
?w=1).This amends all instances of the Benefits section in Understanding pages to be a top-level section with a level-2 heading.
I've tested this with both the XSLT and Eleventy build processes to confirm this doesn't actually change any content, since both build processes already ensure Benefits is a top-level section with level-2 heading. The one exception is the removal of the redundant first Benefits section in Understanding 2.5.3 Label in Name, which only meaningfully affects the XSLT process, as the Eleventy process already worked around that issue.
Note: I don't know what
identify-changes.htmlis supposed to be, but I updated it regardless; it seems to only contain template boilerplate and is not linked from anywhere.