Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
I synced this branch today while looking through old PRs, which required resolving conflicts:
See df64f09e for what was in the original commit of this PR. |
scottaohara
reviewed
May 5, 2025
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…nk text Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
scottaohara
approved these changes
May 5, 2025
kfranqueiro
reviewed
May 9, 2025
Contributor
|
Discussed on backlog call 5/16. We did not resolve if "each landmark region" was equivalent to "same type of landmark". |
Co-authored-by: Kenneth G. Franqueiro <kfranqueiro@users.noreply.github.com>
mbgower
reviewed
Jul 18, 2025
mbgower
reviewed
Jul 21, 2025
mbgower
reviewed
Jul 21, 2025
Contributor
mbgower
left a comment
mbgower
left a comment
There was a problem hiding this comment.
There seems to be a bit of friction between how "name" is used in this document. There is also inconsistency with how "label" and "accessible name" are used. I am making some suggestions to try to improve.
mbgower
reviewed
Jul 21, 2025
mbgower
reviewed
Jul 21, 2025
spelled labeling with only one L not two together (which I think is American usage?) Changed the first use of "label" to "name" to try to better tie in the idea that one typically provides an accessible name for a region through use of an aria label technique.
mbgower
reviewed
Jul 21, 2025
Contributor
|
@mbgower to copy over phrase |
mbgower
reviewed
Jul 25, 2025
Contributor
|
We also need to update lines 49 and 51 in Example 1, as they are not handled as landmarks (missing acc name), even though the title suggests otherwise. |
bruce-usab
approved these changes
Aug 8, 2025
Contributor
patrickhlauke
approved these changes
Aug 18, 2025
Contributor
|
Despite the few thumbs up, there seems to be sufficient support in the comments for this update to technique language. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #919
Also:
role=application(no landmark region)role=region