editorial: [aria.js] generate roleInfo after respec runs#2769
editorial: [aria.js] generate roleInfo after respec runs#2769
Conversation
Rewrites buildRoleInfo.js to make it independent of aria.js
by using the "compiled" specification (after respec runs).
Note: adds several hacks to keep bugs alive (to simplify review).
- .github/worflows/roleInfo.yml
- run on gh-pages pushes (to get latest respec result)
- checkout main
- checkout index.html from gh-pages (to get latest respec result)
- simplify buildRoleInfo.js call
- add reset of index.html
- common/script/ariaPreprocessing.js
- duplicate prohibited and deprecated status for global properties
on list items to preserve it after resolveReferences removes
*ref elements.
- common/script/buildRoleInfo.js
- complete rewrite to run independently from aria.js
- collects states&props
- loops through role sections and processes the characteristics tables
- NOTE: several hacks to recreate bugs (to simplify review)
- common/script/roleInfo.js
- regenerate for review
- all changes are either
- removal of duplicates
- change of position
Part of #2501
pkra
added
the
editorial
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Deployed on https://deploy-preview-2769--wai-aria.netlify.app |
| push: | ||
| branches: | ||
| - main | ||
| - gh-pages |
There was a problem hiding this comment.
I don't know how to test this without merging. Also, this may help with or may be blocked by #2768.
There was a problem hiding this comment.
Only way would be through setting up a fork
There was a problem hiding this comment.
I thought this is the cleanest way: when a version is published to github, we update roleinfo.
| @@ -862,13 +862,6 @@ | |||
| disallowed: false, | |||
| deprecated: false, | |||
| }, | |||
There was a problem hiding this comment.
This diff is worse than my local diff was. Reviewers may want to try to paste this version into their local editor for diffing.
There are a few simple de-duplications as well as a few larger groups (gridcell changes are the most "confusing" part).
Remove output hack after rewrite.
|
Hoping to take a look at this next week! |
| node-version: "latest" | ||
| - run: npm i linkedom prettier@3.6.0 | ||
| - run: node ./common/script/buildRoleInfo.js > ./common/script/roleInfo.js | ||
| - run: node ./common/script/buildRoleInfo.js |
There was a problem hiding this comment.
I am not clear how this check would work. In PRs you don't have the respec esported spec, previews are built at run time.
There was a problem hiding this comment.
Oh! You're right. My brain clearly stopped working at some point.
I'll fix it.
| push: | ||
| branches: | ||
| - main | ||
| - gh-pages |
There was a problem hiding this comment.
Only way would be through setting up a fork
3 participants
🚀 Netlify Preview:
🔄 this PR updates the following sspecs:
Rewrites buildRoleInfo.js to make it independent of aria.js by using the compiled specification (after respec runs). Note: adds several hacks to keep bugs alive (to simplify review).
Part of #2501