fix(display): use matchMedia for mobile breakpoint in useDisplay composable at display.ts (Fixes #23042) - #23129
Open
Tauromachian wants to merge 2 commits into
Open
fix(display): use matchMedia for mobile breakpoint in useDisplay composable at display.ts (Fixes #23042)#23129Tauromachian wants to merge 2 commits into
Tauromachian wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is needed because
createBreakpointanduseDisplayuse different methods to determine themobilecomputed breakpoint.I Updated
useDisplaycomposable inside ofpackages/vuetify/src/composables/display.tsonorigin/nextto usematchMediain a similar fashion tocreateBreakpoints.Fixes #23042
Markup:
There are a lot of cases I wanted to cover, so it makes for a large
Playground.vuefile.