fix(VVirtualScroll): preserve height measurements when items array changes - #23072
Closed
waterWang wants to merge 1 commit into
Closed
fix(VVirtualScroll): preserve height measurements when items array changes#23072waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…anges When using v-virtual-scroll with dynamic heights (item-height="null"), the sizes array was completely reset whenever the items array was reassigned, causing scroll position to jump unexpectedly. This fix preserves existing height measurements for items at the same index, so scroll position remains stable when the items array changes but contains similar items (e.g., expanding/collapsing rows, updating sub-item data). fixes vuetifyjs#22590
Contributor
|
duplicate of #23066 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
v-virtual-scrollwithitem-height="null"(dynamic height), thesizesarray was completely reset whenever theitemsarray was reassigned, causing all previously measured heights to be lost. This caused the scroll position to jump unexpectedly when:Root Cause
In
packages/vuetify/src/composables/virtual.ts, thewatch(items, ...)handler at line 294 was resetting bothsizesandoffsetsarrays to empty arrays of the new length, discarding all previously measured heights.Fix
Instead of creating empty arrays, the fix preserves existing height measurements for items at the same index:
sizesarray before resettingThis way, scroll position remains stable when the items array changes but contains similar items.
Related Issue
Fixes #22590