Skip to content

fix(VMenu): avoid aria-owns for menu activators #23060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vianmangal wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −1
Open

fix(VMenu): avoid aria-owns for menu activators #23060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0414eff
fix(VMenu): avoid aria-owns for menu activators
vianmangal Aug 2, 2026
96dba97
Merge branch 'master' into fix/vmenu-safari-voiceover
vianmangal Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vuetify/src/components/VMenu/VMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export const VMenu = genericComponent<OverlaySlots>()({
'aria-haspopup': 'menu',
'aria-expanded': String(isActive.value),
'aria-controls': id.value,
'aria-owns': id.value,
'data-v-overlay-activator': id.value,
onKeydown: onActivatorKeydown,
}, props.activatorProps)
)
Expand Down
16 changes: 16 additions & 0 deletions packages/vuetify/src/components/VMenu/__tests__/VMenu.spec.browser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@ import { commands, render, screen, userEvent, wait } from '@test'
import { ref } from 'vue'

describe('VMenu', () => {
it('should associate the activator with the menu using aria-controls', () => {
render(() => (
<VMenu>
{{
activator: ({ props }: any) => <VBtn { ...props } data-testid="activator">Menu</VBtn>,
default: () => <VListItem title="Item" />,
}}
</VMenu>
))

const activator = screen.getByTestId('activator')

expect(activator.getAttribute('aria-controls')).toMatch(/^v-menu-v-\d+$/)
expect(activator).not.toHaveAttribute('aria-owns')
})

describe('open-on-focus with template activator', () => {
beforeEach(() => commands.setFocusEmulationDisabled())

Expand Down
Loading