fix(VMenu): remove redundant aria-owns breaking VoiceOver on Safari - #23059
Open
waterWang wants to merge 1 commit into
Open
fix(VMenu): remove redundant aria-owns breaking VoiceOver on Safari#23059waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22540
Problem
The
aria-ownsattribute was added to the VMenu activator in commit 975a18c (PR #22240) alongside the existingaria-controls. On Safari + VoiceOver, this causes the menu item labels to not be read — only "menu item" is announced without the label text.Root Cause
aria-ownson Safari + VoiceOver interferes with the reading of the menu item labels. The reporter confirmed that removingaria-ownsfrom the DOM resolves the issue.Fix
Remove the redundant
aria-ownsattribute from the VMenu activator props. Thearia-controlsattribute already establishes the relationship between the activator and the menu content, makingaria-ownsunnecessary and duplicative.The original issue (#22226) that prompted adding
aria-ownsis still addressed by thearia-controlsattribute, which is the correct ARIA attribute for indicating a controlling relationship between elements.Testing
aria-owns)