Skip to content

fix(icons): remove border box from IconArrowUpSmall - #2164

Open
rodorgas wants to merge 1 commit into
mainfrom
fix/arrow-up-small-border
Open

fix(icons): remove border box from IconArrowUpSmall#2164
rodorgas wants to merge 1 commit into
mainfrom
fix/arrow-up-small-border

Conversation

@rodorgas

@rodorgas rodorgas commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

IconArrowUpSmall had a stray <path> drawing a 0.125px border box around the 16×16 viewBox:

<path
  d="M0.0625 0.0625H15.9375V15.9375H0.0625V0.0625Z"
  vectorEffect="non-scaling-stroke"
  stroke="currentColor"
  strokeWidth="0.125"
/>

Its IconArrowDownSmall counterpart has no such border. This removed the extra path so both small arrow icons render consistently — just the arrow, no surrounding box.

Changes

  • packages/shoreline/src/icons/arrow-up-small.tsx — removed the border <path>.

Session cost

  • Total cost: $0.58 (computed from token usage × huawei/glm-5.2 rates; the vision model has no cost configured so the session-cost script reported $0.00)
  • Agent pi 0.84.2, model huawei/glm-5.2-vision (reasoning: off), 26 assistant turns
  • Token breakdown: 389K input · 7.8K output · 3.5K reasoning · 0 cache-read (~397K total)

IconArrowUpSmall had an extra <path> drawing a 0.125px border around
the 16x16 viewBox, which its IconArrowDownSmall counterpart does not
have. Remove the stray path so both small arrow icons are consistent.
@rodorgas
rodorgas requested a review from a team as a code owner August 26, 2026 18:43
@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
shoreline-docs Ignored Ignored Aug 26, 2026 6:43pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e8133fa-8c69-4c49-9c8b-f397a6fbb6f6

📥 Commits

Reviewing files that changed from the base of the PR and between d833938 and 302b26f.

📒 Files selected for processing (1)
  • packages/shoreline/src/icons/arrow-up-small.tsx
💤 Files with no reviewable changes (1)
  • packages/shoreline/src/icons/arrow-up-small.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

IconArrowUpSmall no longer renders its decorative rectangular border. The upward arrow paths remain unchanged.

Changes

Arrow icon geometry

Layer / File(s) Summary
Remove rectangular border
packages/shoreline/src/icons/arrow-up-small.tsx
The SVG no longer includes the path that rendered the rectangular border. The arrow geometry remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 302b2

This is a small, localized icon-rendering change that removes an unintended border box; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the border box from IconArrowUpSmall.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/arrow-up-small-border

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unintended SVG border path from IconArrowUpSmall so the small up-arrow icon renders consistently (matching the down-arrow variant) without a surrounding 0.125px box.

Changes:

  • Removed the extra <path> that drew a thin border around the 16×16 viewBox in IconArrowUpSmall.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants