fix(icons): remove border box from IconArrowUpSmall - #2164
Conversation
IconArrowUpSmall had an extra <path> drawing a 0.125px border around the 16x16 viewBox, which its IconArrowDownSmall counterpart does not have. Remove the stray path so both small arrow icons are consistent.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesArrow icon geometry
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a small, localized icon-rendering change that removes an unintended border box; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Removes an unintended SVG border path from IconArrowUpSmall so the small up-arrow icon renders consistently (matching the down-arrow variant) without a surrounding 0.125px box.
Changes:
- Removed the extra
<path>that drew a thin border around the16×16viewBox inIconArrowUpSmall.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
IconArrowUpSmallhad a stray<path>drawing a0.125px border box around the16×16viewBox:Its
IconArrowDownSmallcounterpart has no such border. This removed the extra path so both small arrow icons render consistently — just the arrow, no surrounding box.Changes
packages/shoreline/src/icons/arrow-up-small.tsx— removed the border<path>.Session cost