Skip to content

Connecting to socket did not work after support for ipv6 in 5.4.0 #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magnusvin wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Connecting to socket did not work after support for ipv6 in 5.4.0 #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9e118f
Split server and port correctly
magnusvin Oct 5, 2025
9a25176
MySQL: allow empty host
magnusvin Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adminer/drivers/mysql.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function attach(string $server, string $username, string $password): string {
}
list($host, $port) = host_port($server);
return $this->dsn(
"mysql:charset=utf8;host=$host" . ($port ? (is_numeric($port) ? ";port=" : ";unix_socket=") . $port : ""),
"mysql:charset=utf8".(!empty($host) ? ";host=$host" : '') . ($port ? (is_numeric($port) ? ";port=" : ";unix_socket=") . $port : ""),
$username,
$password,
$options
Expand Down
2 changes: 1 addition & 1 deletion adminer/include/functions.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ function is_shortable(array $field): bool {
function host_port(string $server) {
return (preg_match('~^(\[(.+)]|([^:]+)):([^:]+)$~', $server, $match) // [a:b] - IPv6
? array($match[2] . $match[3], $match[4])
: array($server, '')
: (preg_match('~^(\[(.+)]|([^:]+))$~', $server, $match) ? array($match[2] . $match[3], '') : explode(':', $server, 2)) // Match IPv6 or hostname without port, else split by first colon
);
}

Expand Down
Loading