Open
Conversation
Duncaen
requested changes
Apr 8, 2026
Comment on lines
+7
to
+8
| export ND_CONFIGFILE=/var/lib/navidrome/navidrome.toml | ||
| exec chpst -u _navidrome:_navidrome navidrome |
Member
There was a problem hiding this comment.
Suggested change
| export ND_CONFIGFILE=/var/lib/navidrome/navidrome.toml | |
| exec chpst -u _navidrome:_navidrome navidrome | |
| exec chpst -u _navidrome:_navidrome navidrome ${OPTS:- --configfile "/etc/navidrome/navidrome.toml"} |
Its always better to match upstream default locations and services (https://github.com/navidrome/navidrome/blob/4570dec675f904aa0cecd09b2c842685b762527e/contrib/navidrome.service#L14). Config files belong in /etc.
| post_install() { | ||
| vlicense LICENSE | ||
| vmkdir var/lib/navidrome | ||
| vcopy release/linux/navidrome.toml var/lib/navidrome/navidrome.toml |
Member
There was a problem hiding this comment.
Suggested change
| vcopy release/linux/navidrome.toml var/lib/navidrome/navidrome.toml | |
| vinstall release/linux/navidrome.toml 644 etc/navidrome |
| } | ||
|
|
||
| post_install() { | ||
| vlicense LICENSE |
Member
There was a problem hiding this comment.
If this is GPL, the license file doesn't need to be installed.
| system_accounts="_navidrome" | ||
| _navidrome_homedir="/var/lib/navidrome" | ||
| make_dirs="/var/lib/navidrome 0755 _navidrome _navidrome" | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| conf_files="/etc/navidrome/navidrome.toml" |
| revision=1 | ||
| build_style=go | ||
| go_import_path=github.com/navidrome/navidrome | ||
| go_ldflags=" -X github.com/navidrome/navidrome/consts.gitSha=e7c7cba87374ebe1bace57271bc5e8cf731b7a6e -X github.com/navidrome/navidrome/consts.gitTag=v${version}" |
Member
There was a problem hiding this comment.
Things like the commit will end up being outdated, either don't set it or set it to the version.
| go_import_path=github.com/navidrome/navidrome | ||
| go_ldflags=" -X github.com/navidrome/navidrome/consts.gitSha=e7c7cba87374ebe1bace57271bc5e8cf731b7a6e -X github.com/navidrome/navidrome/consts.gitTag=v${version}" | ||
| go_build_tags="netgo,sqlite_fts5" | ||
| hostmakedepends="nodejs pkg-config sqlite-devel taglib-devel" |
Member
There was a problem hiding this comment.
sqlite-devel taglib-devel sound like they belong in makedepends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Local build testing