ensure history db directory exists#573
Merged
oliverkurth merged 6 commits intodevfrom Apr 29, 2026
Merged
Conversation
RPM 6 introduces an unshare plugin which isolates scriptlet execution. In unprivileged docker containers this fails with "Operation not permitted", causing tests that install packages with scriptlets (like test_erase_verbose) to fail. Disable the unshare plugin for pytest. Made-with: Cursor Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
In RPM 6, importing a key that already exists can upgrade its entry in the RPM database from a short ID format to a full fingerprint format (e.g., gpg-pubkey-8a6a826d... becomes gpg-pubkey-0fbe7030...8a6a826d...). When tests imported the VMware key, the setup/teardown logic mistakenly identified the upgraded key format as a entirely new key and deleted it, which then caused the test module's package consistency check to fail since the original key was removed. Update the test logic to identify keys by their short ID suffixes to correctly handle these format upgrades, and ignore gpg-pubkey changes in the global test consistency check. Made-with: Cursor Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
oliverkurth
force-pushed
the
topic/okurth/ensure-history-db-dir
branch
from
fd89e63 to
205bd03
Compare
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
oliverkurth
force-pushed
the
topic/okurth/ensure-history-db-dir
branch
from
205bd03 to
15cc4b1
Compare
oliverkurth
force-pushed
the
topic/okurth/ensure-history-db-dir
branch
3 times, most recently
from
1d25262 to
234e0b8
Compare
sshedi
reviewed
Apr 29, 2026
oliverkurth
force-pushed
the
topic/okurth/ensure-history-db-dir
branch
from
234e0b8 to
bf31bc3
Compare
… SQLITE_BUSY wasn't checked. This lead to invalid entries written to the db, and this caused errors leter when read back. This change also skips over these invalid entries, and adds a busy timeout (500 seconds), to wait when busy instead of exting with SQLITE_BUSY immediately. Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
oliverkurth
force-pushed
the
topic/okurth/ensure-history-db-dir
branch
from
bf31bc3 to
c139cf2
Compare
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
oliverkurth
force-pushed
the
topic/okurth/ensure-history-db-dir
branch
from
c139cf2 to
dc0d1c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lead to invalid entries written to the db, and this caused errors leter when read back.
This change also skips over these invalid entries, and adds a busy timeout (500 seconds),
to wait when busy instead of exting with SQLITE_BUSY immediately.