Skip to content

Show memory leak summary when valgrind check fails #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshedi wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Show memory leak summary when valgrind check fails #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions pytests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,29 @@ def _skip_if_valgrind_disabled(self):
if not self.config['valgrind_enabled']:
pytest.skip(self.config['valgrind_disabled_reason'])

def run_memcheck(self, cmd):
def run_memcheck(self, cmd, assertOnLeak=True):
self._skip_if_valgrind_disabled()
self._decorate_tdnf_cmd_for_test(cmd)

log_file = '/tmp/valgrind_memcheck.log'

memcheck_cmd = ['valgrind',
'--leak-check=full',
'--exit-on-first-error=yes',
'--show-leak-kinds=all',
f'--log-file={log_file}',
'--error-exitcode=1']
return self._run(memcheck_cmd + cmd, retvalonly=True)

ret = self._run(memcheck_cmd + cmd, retvalonly=True)
rc = ret['retval']

if assertOnLeak:
if rc and os.path.exists(log_file):
with open(log_file, 'r') as f:
print(f.read(), file=sys.stderr)
assert False, "valgrind memory leak check failed"

ret['valgrind_logfile'] = log_file
return ret

def run(self, cmd, cwd=None, noconfig=False):
if isinstance(cmd, str):
Expand Down
Loading