[CI] Support custom Buildkite agent tags in pipeline generator#338
Draft
zxd1997066 wants to merge 1 commit intovllm-project:mainfrom
Draft
[CI] Support custom Buildkite agent tags in pipeline generator#338zxd1997066 wants to merge 1 commit intovllm-project:mainfrom
zxd1997066 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Collaborator
|
We also keep the logic to route to agents queue based on mapping for security reason. The job specs from upstream cannot define agent queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom tags in the pipeline generator.
Previously, generated steps only set agents.queue from device-based mapping.
agents={"queue": get_agent_queue(step)}With this change, a step can define additional agent constraints and they will be merged into the generated agents map.