Clean up buildkite_step.py: fix import, remove dead code#321
Open
Clean up buildkite_step.py: fix import, remove dead code#321
Conversation
…g print - Move `import re` from inside loop to module level - Fix inconsistent DeviceType .value comparisons in _get_step_plugin - Remove leftover debug print(variables_to_inject) - Remove unused parameter and dead branch in _create_block_step - Remove dead amd_block_step = None assignment and always-true guard Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import refrom inside a for-loop body to module level_get_step_plugin()to compare againstDeviceType.H100/DeviceType.A100enum members instead of their.valuestringsprint(variables_to_inject)inconvert_group_step_to_buildkite_step()list_file_diffparameter and deadif step.label.startswith(":docker:")branch in_create_block_step()amd_block_step = Noneassignment and always-trueif amd_block_step:guard_create_block_step()and_generate_step_key()Test plan
python3 -m pytest tests/test_buildkite_step.py -v-- 17 tests pass🤖 Generated with Claude Code