feat: Remove address cloning#179
Merged
Merged
Conversation
Member
|
Maybe write address to |
(this is what previously the address cloning did)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the address cloning mechanism that was previously used to snapshot
shipping addresses during order freeze. Instead, address data is now persisted
directly via relational bone configuration.
Before: When freezing an order/cart,
clone_address()created a full copyof the address record and stored a
cloned_fromback-reference.After:
CartNodeSkel.shipping_address(and the corresponding bone inOrderSkel) usesrefKeys="*"withupdateLevel=UpdateLevel.OnValueAssignment,capturing the full address at assignment time. Additionally,
shipping_addressis added to
frozen_valuesonCartNodeSkelto prevent later mutation.Changes
clone_address()method and all call sites incart.py/order.pycloned_fromRelationalBonefromAddressSkelrefKeys="*"andupdateLevel=UpdateLevel.OnValueAssignmenton shippingaddress bones in cart/order skeletons
shipping_addresstoCartNodeSkel.frozen_valuesshop_addressDatastore index oncloned_fromviur.shop.skeleton.address.cloned_fromtranslation keys