Skip to content

chore(deps): bump @types/chai to 5.0.1#7123

Merged
hi-ogawa merged 12 commits into
vitest-dev:mainfrom
nopeless:bump-chai-types-to-5.0.1
Mar 1, 2025
Merged

chore(deps): bump @types/chai to 5.0.1#7123
hi-ogawa merged 12 commits into
vitest-dev:mainfrom
nopeless:bump-chai-types-to-5.0.1

Conversation

@nopeless
Copy link
Copy Markdown
Contributor

Description

#7121 cc @hi-ogawa

fix broken vitest assert types

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci. (vitest/test/config/fixtures/exec-args-fixtures/vmThreads.test.ts fails for some reason)

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@nopeless
Copy link
Copy Markdown
Contributor Author

note: I haven't actually checked if the typings work now, but based on a simple diff between v4 and v5, I concluded that bumping the version will fix the issue

@nopeless
Copy link
Copy Markdown
Contributor Author

welp ci is breaking, idk y

@nopeless
Copy link
Copy Markdown
Contributor Author

nopeless commented Dec 24, 2024

I am not entirely sure why 2130edc is required for build to succeed. I am also not sure why simply building the repository causes cced3ff either

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 24, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 15ff9e3
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67c27249f3b1870008ce7bf3
😎 Deploy Preview https://deploy-preview-7123--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nopeless
Copy link
Copy Markdown
Contributor Author

ci based tdd

@nopeless
Copy link
Copy Markdown
Contributor Author

found out the type issue

Caused by this commit 5f4774f

I am not sure why he is inlining chai types when he already patched it? anyway, this is out of my decision.

This was not an issue in the previous @types/chai

4.3.6

declare namespace Chai {

5.0.1

declare global {
    namespace Chai {

@sheremet-va I would like to know how you would approach this issue

also I am not willing to fix the failing test as I have no idea why it fails

@hi-ogawa
Copy link
Copy Markdown
Collaborator

hi-ogawa commented Dec 26, 2024

Hey, thanks for bringing the PR 👋
I suggested it without knowing much, but it looks fairly messy. Don't worry about this and we can take over this.

The idea of not having @types/chai in dependencies removes certain frictions in ts setup, so I get the idea. I'll push a few changes to test something.


Though patch is getting uglier, the basic typing should be working like before https://stackblitz.com/edit/vitest-dev-vitest-xrmchgds?file=test%2Fbasic.test.ts

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 26, 2024

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7123

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7123

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7123

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7123

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7123

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7123

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7123

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7123

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7123

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7123

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7123

vite-node

npm i https://pkg.pr.new/vite-node@7123

vitest

npm i https://pkg.pr.new/vitest@7123

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7123

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7123

commit: 15ff9e3

@hi-ogawa hi-ogawa changed the title chore: bump @types/chai to 5.0.1 chore(deps): bump @types/chai to 5.0.1 Dec 26, 2024
@hi-ogawa hi-ogawa added the p2-to-be-discussed Enhancement under consideration (priority) label Jan 6, 2025
@hi-ogawa
Copy link
Copy Markdown
Collaborator

hi-ogawa commented Mar 1, 2025

Merging as this has been approved in the past team meeting.

@hi-ogawa hi-ogawa merged commit 80cd129 into vitest-dev:main Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cr-tracked p2-to-be-discussed Enhancement under consideration (priority)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants