-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Move to yarn 4 and workspaces #10321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 4 commits
7e98ba8
59276c4
86232ca
ae5719c
2027e7f
529e5a2
c0c1e63
9555cb1
61d9e8d
258145b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,13 +24,25 @@ jobs: | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CI cache removed without replacement, causing slower buildsMedium Severity The Additional Locations (2)Reviewed by Cursor Bugbot for commit 258145b. Configure here. |
||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable yarn | ||
| - name: Enable Corepack / Yarn 4 | ||
| run: | | ||
| corepack enable | ||
| corepack prepare "$(node -p "require('./package.json').packageManager")" --activate | ||
| yarn -v | ||
|
|
||
| - name: Cache Yarn 4 artifacts | ||
| uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0 | ||
| with: | ||
| path: | | ||
| ~/.yarn/berry/cache | ||
| .yarn/install-state.gz | ||
| key: ${{ runner.os }}-yarn4-${{ hashFiles('yarn.lock', '.yarnrc.yml', 'package.json') }} | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn bootstrap | ||
| run: | | ||
| yarn install --immutable | ||
| yarn bootstrap | ||
|
|
||
| - name: Build packages | ||
| run: yarn build | ||
|
|
@@ -73,13 +85,27 @@ jobs: | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable yarn | ||
| - name: Enable Corepack / Yarn 4 | ||
| run: | | ||
| corepack enable | ||
| corepack prepare "$(node -p "require('./package.json').packageManager")" --activate | ||
| yarn -v | ||
|
|
||
| - name: Cache Yarn 4 artifacts | ||
| uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0 | ||
| with: | ||
| path: | | ||
| ~/.yarn/berry/cache | ||
| .yarn/install-state.gz | ||
| website/.yarn/cache | ||
| website/.yarn/install-state.gz | ||
| key: ${{ runner.os }}-yarn4-${{ hashFiles('yarn.lock', '.yarnrc.yml', 'package.json', 'website/yarn.lock', 'website/.yarnrc.yml', 'website/package.json') }} | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn bootstrap | ||
| run: | | ||
| yarn install --immutable | ||
| yarn bootstrap | ||
|
|
||
| - name: Build packages | ||
| run: yarn build | ||
|
|
@@ -97,16 +123,28 @@ jobs: | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable yarn | ||
| - name: Enable Corepack / Yarn 4 | ||
| run: | | ||
| corepack enable | ||
| corepack prepare "$(node -p "require('./package.json').packageManager")" --activate | ||
| yarn -v | ||
|
|
||
| - name: Cache Yarn 4 artifacts | ||
| uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0 | ||
| with: | ||
| path: | | ||
| ~/.yarn/berry/cache | ||
| .yarn/install-state.gz | ||
| key: ${{ runner.os }}-yarn4-${{ hashFiles('yarn.lock', '.yarnrc.yml', 'package.json') }} | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5 | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| yarn install --immutable | ||
| yarn bootstrap | ||
| cd bindings/pydeck | ||
| make setup-env | ||
| make init | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| enableScripts: true | ||
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| logFilters: | ||
| - code: YN0060 | ||
| pattern: "*@types/react is listed by your project with version 18.3.28*" | ||
| level: discard | ||
| - code: YN0060 | ||
| pattern: "*react is listed by your project with version 18.3.1*" | ||
| level: discard | ||
| - code: YN0060 | ||
| pattern: "*react-dom is listed by your project with version 18.3.1*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @deck.gl/extensions*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @deck.gl/mesh-layers*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @loaders.gl/core*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @luma.gl/core*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @luma.gl/engine*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @luma.gl/shadertools*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @luma.gl/webgl*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide @luma.gl/webgpu*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide esri-loader*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide react*" | ||
| level: discard | ||
| - code: YN0002 | ||
| pattern: "*doesn't provide react-dom*" | ||
| level: discard | ||
| - code: YN0086 | ||
| pattern: "*Some peer dependencies are incorrectly met*" | ||
| level: discard |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into if this increases build times