-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Move to yarn 4 and workspaces #10321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 6 commits
7e98ba8
59276c4
86232ca
ae5719c
2027e7f
529e5a2
c0c1e63
9555cb1
61d9e8d
258145b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,13 +24,14 @@ jobs: | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CI cache removed without replacement, causing slower buildsMedium Severity The Additional Locations (2)Reviewed by Cursor Bugbot for commit 258145b. Configure here. |
||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable yarn | ||
| run: corepack enable | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn bootstrap | ||
| run: | | ||
| yarn install --immutable | ||
| yarn bootstrap | ||
|
|
||
| - name: Build packages | ||
| run: yarn build | ||
|
|
@@ -73,13 +74,14 @@ jobs: | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable yarn | ||
| run: corepack enable | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn bootstrap | ||
| run: | | ||
| yarn install --immutable | ||
| yarn bootstrap | ||
|
|
||
| - name: Build packages | ||
| run: yarn build | ||
|
|
@@ -97,16 +99,17 @@ jobs: | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable yarn | ||
| run: corepack enable | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5 | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| yarn install --immutable | ||
| yarn bootstrap | ||
| cd bindings/pydeck | ||
| make setup-env | ||
| make init | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| enableScripts: true | ||
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| logFilters: | ||
| - code: YN0002 | ||
| level: discard | ||
| - code: YN0060 | ||
| level: discard | ||
| - code: YN0086 | ||
| level: discard |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,10 +18,10 @@ import Long from 'long'; | |
| * Given an S2 token this function convert the token to 64 bit id | ||
| https://github.com/google/s2-geometry-library-java/blob/c04b68bf3197a9c34082327eeb3aec7ab7c85da1/src/com/google/common/geometry/S2CellId.java#L439 | ||
| * */ | ||
| function getIdFromToken(token: string): number { | ||
| function getIdFromToken(token: string): string { | ||
| // pad token with zeros to make the length 16 | ||
| const paddedToken = token.padEnd(16, '0'); | ||
| return Long.fromString(paddedToken, 16); | ||
| return Long.fromString(paddedToken, 16).toString(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's split this out
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand that having seemingly unrelated changes in a PR is annoying but this is related to typescript version being bumped as part of satisfying all the package.json.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just want to make sure we're thinking through the implications and covering bug fixes with tests. I'm only focusing on testing the build system in this PR |
||
| } | ||
|
|
||
| const MAX_RESOLUTION = 100; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,9 @@ | |
| ], | ||
| "sideEffects": false, | ||
| "scripts": { | ||
| "watch": "npm run build -- --watch", | ||
| "build": "ocular-bundle ./src/index.js --output=./dist/index.js --globalName= --sourcemap --format=umd --externals=@jupyter-widgets/base", | ||
| "watch": "npm run build-bundle -- --watch", | ||
| "build": "npm run build-bundle", | ||
| "build-bundle": "ocular-bundle ./src/index.js --output=./dist/index.js --globalName= --sourcemap --format=umd --externals=@jupyter-widgets/base", | ||
|
Comment on lines
25
to
+28
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this change? |
||
| "build:labextension": "npm pack", | ||
| "prepublishOnly": "npm run build" | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| enableScripts: true | ||
|
|
||
| nodeLinker: node-modules |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,5 @@ docusaurus build | |
| # build gallery (scripting) examples | ||
| ( | ||
| cd ../examples/gallery | ||
| yarn | ||
| yarn build | ||
| ) | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into if this increases build times