chore: pin ty check execution#69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tyto the project dev dependency flow so it is resolved throughuv.lockty-checkhook viauv run --locked ty checkinstead of floatinguvx ty checktyignoresWhy
CI was running
tythroughuvx, which fetches the current published package rather than the project lockfile. That let type-checker drift break unrelated PR CI. This makes the hook deterministic and clears the diagnostics currently present onmain.Verification
uv run --locked ty check --python=.venv/ --exclude=examples/uv run --locked pytest tests/test_api.py tests/test_core.pyuv run --locked prek run -a$code-reviewreview loop: no findings