feat(poster): add support for marking player as maincontent#9173
feat(poster): add support for marking player as maincontent#9173kontrollanten wants to merge 2 commits intovideojs:mainfrom
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9173 +/- ##
==========================================
+ Coverage 84.32% 84.94% +0.62%
==========================================
Files 120 120
Lines 8153 8157 +4
Branches 1964 1967 +3
==========================================
+ Hits 6875 6929 +54
+ Misses 1278 1228 -50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When maincontent is set to true the poster img element will get loading=eager and fetchpriority=high to decrease LCP time. closes videojs#9171
ae70f2a to
b30ad53
Compare
|
At the time Nit: The option name should be camel case like other options. |
|
Thanks for reviewing! I've now changed |
Description
When maincontent is set to true the poster img element will get loading=eager and fetchpriority=high to decrease LCP time.
Usage
maincontent: true
Default mode
Requirements Checklist
npm run docs:apito errorI'm not sure if any example should be created, and if so where to put it. The same goes with the documentation.
closes #9171