Security Audit Fix#9166
Open
danrossi wants to merge 9 commits intovideojs:mainfrom
Open
Conversation
- move to pa11y for accessibility tester
- elliptic 6.6.1 is still vulnerable. So browserify package is vulnerable with no fix.
Author
|
I cleaned up the overrides better. However there is no fix for browserify because the elliptic package is still vulnerable. If browserify is just used for a test file it might be safe to remove for now. |
Author
|
There is two Axios flaws now along with the other security audit fixes. Video.JS pulls this in for an old accessibility tester package. This migrates to a different tester. |
Author
|
a lock file update fixes the xml vulnerability issue. There is just browserify which is used for a test. Might be easier to just remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was security audit errors that were critical related to installing a vulnerable Axios package via the access-sniff package. The browserify package security issue is low but unfixable and won't override the set packages. It is needed only for a test file so should be removed maybe.
There is alot of deprecated warnings that may be hard to fix. "videojs-standard" uses an old eslint which has an api change in 8.0.0.
Specific Changes proposed
This updates packages with overrides to fix the security audit issues
The access-sniff accessibility test has been changed to a pa11y accessibility test report. So that old outdated package can be removed. Some overrides wouldn't fix it's problem so safe to remove.