fix: simplify getBoundingClientRect wrapper#9150
Open
PascalThuet wants to merge 3 commits intovideojs:mainfrom
Open
fix: simplify getBoundingClientRect wrapper#9150PascalThuet wants to merge 3 commits intovideojs:mainfrom
PascalThuet wants to merge 3 commits intovideojs:mainfrom
Conversation
Remove the IE8 computedStyle fallback and the shallow-copy to a plain object. All modern browsers provide height/width on DOMRect and no call site in the codebase mutates the returned rect, so we can safely return the native DOMRect directly. Fixes videojs#9149
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9150 +/- ##
=======================================
Coverage 84.32% 84.33%
=======================================
Files 120 120
Lines 8153 8144 -9
Branches 1964 1961 -3
=======================================
- Hits 6875 6868 -7
+ Misses 1278 1276 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PascalThuet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computedStylefallback that was added for IE8 compatibility (no longer supported)DOMRectdirectly instead of shallow-copying to a plain objectAll call sites (
seek-bar.js,time-tooltip.js,volume-bar.js,volume-level-tooltip.js) only read properties from the returned rect — none mutate it — so returning the nativeDOMRectis safe.Test plan
getBoundingClientRecttest)Fixes #9149