-
Notifications
You must be signed in to change notification settings - Fork 1
Add Platform Router and Triton implementation #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yfan-viant
wants to merge
14
commits into
dev
Choose a base branch
from
ML-893-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f164b1e
Add Platform Router and Triton implementation
yfan-viant 8386ed0
Fix endly tests
yfan-viant bbcdbef
Address code review comments
yfan-viant a51ad4a
Remove PlatformRouter interface and tfService from service struct
yfan-viant a461c5e
Cache input config and add output config detection
yfan-viant b501043
Minor updates to address comments
yfan-viant 9ed7970
Remove Input interface and force Triton config to include output field
yfan-viant 458d4f8
Clean up unit tests no longer needed. Remove unused versioning
yfan-viant 9778cae
ML-893 Adding endly test for Triton
tkrishnaviant a712da0
Update signature to exlude auxiliary inputs
yfan-viant 4b91e5c
ML-893 endly test for Triton will go thru mly
tkrishnaviant ed09514
Pseudo-squash merge endly-fix, add hack to support port 8000 for Triton.
dchoi-viant 5ba2ede
Fix issues with Triton test case.
dchoi-viant 227ece5
Update PlatformEvaluator interface for API health. Implement cache of…
yfan-viant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package platform | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/viant/afs" | ||
| "github.com/viant/gmetric" | ||
| "github.com/viant/mly/service/config" | ||
| "github.com/viant/mly/service/tfmodel" | ||
| "golang.org/x/sync/semaphore" | ||
| ) | ||
|
|
||
| // CreateEvaluator creates the appropriate platform evaluator based on the model configuration | ||
| func CreateEvaluator(cfg *config.Model, fs afs.Service, metrics *gmetric.Service, sema *semaphore.Weighted, maxEvaluatorWait time.Duration) (PlatformEvaluator, ModelPlatform, error) { | ||
| platform := cfg.GetPlatform() | ||
|
|
||
| switch platform { | ||
| case "tensorflow": | ||
| // Create TensorFlow service using existing code | ||
| tfService := tfmodel.NewService(cfg, fs, metrics, sema, maxEvaluatorWait) | ||
| evaluator := NewTensorFlowEvaluator(tfService) | ||
| return evaluator, PlatformTensorFlow, nil | ||
|
|
||
| case "triton": | ||
| evaluator := NewTritonEvaluator(cfg) | ||
| return evaluator, PlatformTriton, nil | ||
|
|
||
| default: | ||
| return nil, "", fmt.Errorf("unsupported platform: %s for model %s", platform, cfg.ID) | ||
| } | ||
| } | ||
|
|
||
| // CreateEvaluatorContext creates a platform evaluator with context | ||
| func CreateEvaluatorContext(cfg *config.Model, fs afs.Service, metrics *gmetric.Service, sema *semaphore.Weighted, maxEvaluatorWait time.Duration) (*PlatformEvaluatorContext, error) { | ||
| evaluator, platform, err := CreateEvaluator(cfg, fs, metrics, sema, maxEvaluatorWait) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return NewEvaluatorContext(cfg, evaluator, platform), nil | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.