Upgrade go.viam.com/rdk to v0.126.1#189
Open
NickPPC wants to merge 1 commit into
Open
Conversation
Adapt to the new vision API in customerdetector: vis.Detections now takes *camera.NamedImage instead of image.Image. Wrap the captured frame with camera.NamedImageFromImage before invoking the detector. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
01b82e7 to
67330c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
go.viam.com/rdkfromv0.119.2tov0.126.1(latest stable) and adapts the customer detector to the new vision API.Changes
go.viam.com/rdkv0.119.2 → v0.126.1,go.viam.com/apiv0.1.533 → v0.1.545,go.viam.com/utilsv0.4.13 → v0.4.19, plus transitive bumps (grpc,gonum,pion/mediadevices, etc.) fromgo mod tidy.vision.Service.Detectionsnow takes*camera.NamedImageinstead ofimage.Image. Wrap the captured frame withcamera.NamedImageFromImagebefore invoking the detector; addgo.viam.com/rdk/dataimport fordata.Annotations{}.gofmt -swhitespace alignment in avar (...)block (no semantic change).Compatibility note
The
Detectionssignature change is purely client-side. The underlyingGetDetectionsRequestgRPC payload (Name, Image bytes, Width, Height, MimeType, Extra) is unchanged between v0.119.2 and v0.126.1, so the vision-service module running on the machine does not need to be upgraded.Testing
make— builds cleanmake test— all package tests pass (beanjamin,multiposesexecutionswitch)go vet ./...— cleanNote:
make lintcannot run locally because the installedgolangci-lintis v1 but the repo config is v2 — pre-existing toolchain issue unrelated to this change. CI will run the right version.Claude Code Prompts Used
🤖 Generated with Claude Code