Firecracker snapshot upf ctriface#928
Open
char-1ee wants to merge 21 commits into
Open
Conversation
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjian@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Contributor
Author
ustiugov
reviewed
Feb 2, 2024
ustiugov
left a comment
ustiugov
left a comment
Member
There was a problem hiding this comment.
most importantly, please fix the naming
Signed-off-by: char-1ee <xingjianli59@gmail.com>
ustiugov
reviewed
Feb 5, 2024
char-1ee
force-pushed
the
firecracker-snapshot-upf-ctriface
branch
from
1324e37 to
e8092e4
Compare
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
char-1ee
force-pushed
the
firecracker-snapshot-upf-ctriface
branch
from
d3c914e to
f294880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an informal PR for debugging. Please DO NOT merge.
firecracker-snapshot-upf-testbranch: https://github.com/char-1ee/vHive/tree/firecracker-snapshot-upf-test../vhive_test.go./ctriface/iface_test.go, which contains theTestStartSnapStop()fromfailing_test.go.