test(eve): hold busy-worker until steering begins - #3139
Closed
ruiconti wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Rui Conti <ruiconti@gmail.com>
Contributor
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The busy-worker eval can miss the state it intends to test: in the failed run, the child completed before the later continuation arrived. Hold the child at an approval gate and wait until that gate is visible before steering it. The eval then checks that steering cancels the held task and completes a replacement on the same agent, without relying on the five-second delay.
Extracted from #3073; this fixture fix is independent of workflow authorization.
Validation
pnpm typecheck: 44 tasks passed, including building and typecheckingfixture-tasks.pnpm --filter fixture-tasks validate:transitions: 19 declarations passed.pnpm fmtandpnpm lintpassed.Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)