fix(consolidation): expose failed LLM batches - #4164
Closed
koriyoshi2041 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Two CI failures look unrelated to this metrics-only diff:
I cannot rerun upstream jobs from the fork. Could a maintainer rerun the failed jobs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4151.
What changed
Add
hindsight.consolidation.batch_failures, a counter for LLM batches that exhaust consolidation's retry policy. It uses a boundedreasonlabel:response_validationfor malformed JSON, schema validation, and output-length failuresproviderfor other exhausted provider failuresThe existing
failed_consolidationgauge remains unchanged: it counts source memories permanently marked failed after adaptive bisection reaches a singleton. The new counter makes recoverable batch-level failures visible without changing that state-based contract.Each failed batch increments once after its retry ladder, rather than once per attempt. Successful batches do not increment it.
Verification
tests/test_metrics.py: 34 passedTestBuildResponseModel: 10 passedgit diff --checkpassedThe repository hook reached the control-plane lint step but could not load
@eslint/jsbecause Node dependencies are not installed in this worktree. The changed Python files and tests passed their focused gates.