feat(obsidian): support observation scopes - #3846
Conversation
Strix Security ReviewWarning This pull request has 1 commit after the last Strix review ( No security issues found. Updated for Reviewed by Strix |
Sanderhoff-alt
left a comment
There was a problem hiding this comment.
The field name, the four accepted values and the per-item placement all match MemoryItem.observation_scopes in hindsight-api-slim/hindsight_api/api/http.py:716, and saveSettings() rebuilds the engine so the dropdown takes effect immediately. Two items before merge.
|
@Sanderhoff-alt Thanks for the review — both items are addressed in 788bdbf: the requested Prettier reflows are committed, and observationScopes now flows through remembered user and assistant chat retains with focused coverage. Local verification passed TypeScript lint, all 113 tests, production build, Prettier check, and git diff check. Could you please re-review when convenient? |
|
@strix-security please re-run the security review for the latest commit. |
Summary
observation_scopessupport to the Obsidian retain clientSyncEnginepathThis supports banks where trusted ingestion sources need to consolidate observations together while retaining vault/folder/date/frontmatter tags for filtering and provenance. Existing documents are not automatically migrated when the setting changes.
Test plan
npm run lintnpm test(113 tests)npm run buildgit diff --check