Skip to content
This repository was archived by the owner on Feb 16, 2026. It is now read-only.

req_fsm: Always run vcl_synth upon client req reset #4412

Open
dridi wants to merge 3 commits into
base: master
Choose a base branch
from
+29 −14
Open

req_fsm: Always run vcl_synth upon client req reset #4412

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
748704a
req_fsm: Clear stale reference to req->hash_objhead
dridi Oct 30, 2025
ea0ea5e
req_fsm: Export R_STP_SYNTH
dridi Nov 5, 2025
b9c89f1
req_fsm: Always run vcl_synth upon client req reset
dridi Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bin/varnishd/cache/cache_req_fsm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,9 +596,9 @@ cnt_lookup(struct worker *wrk, struct req *req)
if (lr == HSH_BUSY) {
/*
* We lost the session to a busy object, disembark the
* worker thread. We return to STP_LOOKUP when the busy
* object has been unbusied, and still have the objhead
* around to restart the lookup with.
* worker thread. We return to R_STP_LOOKUP, with the

@nigoroll nigoroll Nov 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message sounds like there would be more to it, but this is really just a comment fix?

@dridi dridi Nov 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this describes the old waiting list system with the retired hash_objhead field. I noticed this while surveying the req_reset behavior because we have more waiting list features on the Enterprise side (primarily #3835).

There was no reason to omit it from this patch series.

@nigoroll nigoroll Nov 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was really only asking because the commit message " req_fsm: Clear stale reference to req->hash_objhead" sounds like you had other intentions than only polishing a comment.

* object still around when it has been unbusied, to
* restart the lookup with.
*/
return (REQ_FSM_DISEMBARK);
}
Expand Down