Skip to content

GHi-658: Deleting process definitions not cleaning up linked tables correctly - #907

Open
marijnritense wants to merge 5 commits into
next-minorfrom
bugfix/ghi658-deleting-process-definitions-bug
Open

GHi-658: Deleting process definitions not cleaning up linked tables correctly#907
marijnritense wants to merge 5 commits into
next-minorfrom
bugfix/ghi658-deleting-process-definitions-bug

Conversation

@marijnritense

Copy link
Copy Markdown
Collaborator

…n't all cleaned up correctly because a specific event wasn't being thrown. Also fixed this retroactively with liquibase changesets
@marijnritense
marijnritense requested review from a team as code owners August 13, 2026 12:00
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@marijnritense, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 109 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1da2bcd7-dea6-4c15-88dc-2b59f55c640d

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb3225 and 7ba8ea7.

📒 Files selected for processing (1)
  • documentation/release-notes/13.x.x/13.42.0/README.md
📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Fixed cleanup of linked case-definition records when processes are deleted.
    • Removed orphaned process links automatically during upgrade.
    • Improved deletion events to retain related blueprint information.
    • Ensured related building-block links are also removed when orphaned links are cleaned up.
  • Documentation

    • Added release notes describing process and case-definition link cleanup.

Walkthrough

Process deletion publishing now emits ProcessDefinitionDeleted with the process definition ID and a blueprint ID derived from the version tag. A Liquibase 13.42.0 migration removes orphaned process_definition_case_definition and process_link records. Integration tests verify deletion of orphaned rows and retention of valid rows. Release notes document the cleanup behavior.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/ghi658-deleting-process-definitions-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cf96bfc5-c5b4-4bc2-b898-97f0278c8949

📥 Commits

Reviewing files that changed from the base of the PR and between d95fdb4 and 6eb3225.

📒 Files selected for processing (2)
  • backend/core/src/test/kotlin/com/ritense/valtimo/liquibase/DeleteOrphanedProcessDefinitionLinksIntTest.kt
  • documentation/release-notes/13.x.x/13.42.0/README.md

Comment thread documentation/release-notes/13.x.x/13.42.0/README.md Outdated
@ivo-ritense ivo-ritense added the test env Create a remote test environment for this PR in the Ritense product development cluster label Aug 14, 2026
@ivo-ritense ivo-ritense added tested and removed test env Create a remote test environment for this PR in the Ritense product development cluster labels Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants