chore: resolve high-severity frontend dependency alerts - #893
Conversation
Update js-yaml, fast-uri, ip-address, postcss and brace-expansion to patched versions, using overrides where a parent package pinned them.
|
Warning Review limit reached
Next review available in: 109 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe frontend dependency configuration adds overrides for 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Klaas-Ritense
added
the
test env
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 93586fdf-dfa9-4896-8c01-af7782e78398
⛔ Files ignored due to path filters (1)
frontend/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
documentation/release-notes/13.x.x/13.41.0/README.mdfrontend/package.json
…end-high-severity-deps Nightly maintenance run. One conflict, in documentation/release-notes/13.x.x/13.41.0/README.md: both sides appended to the same release note. Kept both — next-minor's "Exporting case definitions" bugfix at the end of the Bugfixes list, then this branch's new Security section after it.
Nightly maintenance run. - documentation/release-notes/13.x.x/13.41.0/README.md:80 — applied the reviewer's committable suggestion verbatim: "Addressed several reported high-severity front-end security alerts" rather than "the reported", and named the Swagger UI `immutable` alert explicitly, so the note does not read as though every alert was fixed.
…end-high-severity-deps
Nightly maintenance run. - Moved the front-end security alerts note from 13.41.0 to 13.42.0, which is the current release-notes folder on next-minor.
…end-high-severity-deps # Conflicts: # documentation/release-notes/13.x.x/13.42.0/README.md
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
documentation/release-notes/13.x.x/13.42.0/README.md (1)
9-11: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winRemove the template placeholders before publishing.
If this is the final
13.42.0release note, replace or removeNew feature title,New feature explanation,New enhancement title,New enhancement explanation, andNew bugfix.Also applies to: 15-17, 21-21
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 90f48390-d904-4469-b9f0-f7795ce4bf51
📒 Files selected for processing (1)
documentation/release-notes/13.x.x/13.42.0/README.md
…end-high-severity-deps
…form#893) * chore: resolve high-severity frontend dependency alerts Update js-yaml, fast-uri, ip-address, postcss and brace-expansion to patched versions, using overrides where a parent package pinned them. * chore: apply review feedback Nightly maintenance run. - documentation/release-notes/13.x.x/13.41.0/README.md:80 — applied the reviewer's committable suggestion verbatim: "Addressed several reported high-severity front-end security alerts" rather than "the reported", and named the Swagger UI `immutable` alert explicitly, so the note does not read as though every alert was fixed. * docs: move release note to 13.42.0 Nightly maintenance run. - Moved the front-end security alerts note from 13.41.0 to 13.42.0, which is the current release-notes folder on next-minor.
2 participants
https://github.com/generiekzaakafhandelcomponent/atlas-internal/issues/566
Resolves the high-severity Dependabot alerts on
frontend/package-lock.jsonthat can be fixed without amajor upgrade.
js-yaml(4.3.1),fast-uri(3.1.5),ip-address(10.5.0),postcss(8.5.26) andbrace-expansion(2.1.4 / 5.0.9) now resolve to patched versions — viaoverrideswhere a parent packagepinned them. Nine high alerts drop to eight. No functional change.
postcssneeded an override because@angular-devkit/build-angularpins it to8.5.12exactly. Onlyminimatch@9pulls the vulnerablebrace-expansion2.x line, so that override is version-scoped to leavethe 1.x and 5.x copies untouched.
Scope
The ticket title says HIGH, so this covers high severity in the frontend lockfile only. The screenshot is
cropped mid-row, so I worked from the live alert list rather than the three visible entries — that turned
out to be nine highs, not three.
npm auditalso surfaced ajs-yamladvisory newer than the screenshot(
<4.3.1), hence 4.3.1 rather than the 4.3.0 Dependabot currently suggests.Deliberately left out
immutable3.8.3 underswagger-ui(2 high). Fixed upstream inswagger-ui@5.32.11, which requiresswagger-client >=3.37.7, which declaresengines.node: ">=22". This repo is Node 20 (engines,engine-strict=truein.npmrc, CINODE_VERSION: "20.x"), so the install hard-fails. I did not forceimmutable 4 into
swagger-ui@5.21.0via an override — upstream needed a source migration to make thatjump, so pinning it would likely break the Swagger page at runtime. Raising the platform's Node baseline
to 22 is a decision that warrants its own ticket.
@angular/*,@angular-devkit/build-angular,image-size,less(5 high). Only fix is Angular19 → 21. Already tracked against the next major Angular upgrade in the 13.39.0 release notes.
Verification
npm ci --dry-run— lockfile and manifest in sync.npm run libs-build-all— all libraries built, exit 0.@valtimo-plugins/*packages that CI injects and that are not declared inpackage.json, and the pageneeds a running backend. The
js-yamlmove is within major 4, and upstreamswagger-uiitself pins=4.3.0from 5.32.10, so the risk is low but untested.