[DRAFT] Playwright tests #858
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| export { | ||
| BUILDING_BLOCK_MANAGEMENT_LIST_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_CREATE_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_UPLOAD_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_DETAIL_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_METADATA_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_ARTWORK_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_PLUGINS_TEST_IDS, | ||
| BUILDING_BLOCK_MANAGEMENT_DETAIL_ACTIONS_TEST_IDS, | ||
| BUILDING_BLOCK_VERSION_OPTION_TEST_ID_PREFIX, | ||
| } from '../../frontend/projects/valtimo/building-block-management/src/lib/constants/building-block-management.test-ids'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright 2015-2026 Ritense BV, the Netherlands. | ||
| * | ||
| * Licensed under EUPL, Version 1.2 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" basis, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import {expect, type Locator, type Page} from '@playwright/test'; | ||
|
|
||
| /** | ||
| * Wrapper for the Valtimo `v-overflow-menu` component (the "More" menus in | ||
| * admin detail headers and carbon-list rows). | ||
| * | ||
| * The menu content is rendered in an overlay outside the trigger, so options are | ||
| * looked up page-wide rather than inside the trigger element. Options are only | ||
| * present in the DOM while the menu is open. | ||
| */ | ||
| export class OverflowMenu { | ||
| constructor( | ||
| private readonly page: Page, | ||
| private readonly triggerTestId: string | ||
| ) {} | ||
|
|
||
| get trigger(): Locator { | ||
| return this.page.getByTestId(this.triggerTestId); | ||
| } | ||
|
|
||
| get menu(): Locator { | ||
| return this.page.getByRole('menu'); | ||
| } | ||
|
|
||
| option(optionTestId: string): Locator { | ||
| return this.page.getByTestId(optionTestId); | ||
| } | ||
|
|
||
| async open() { | ||
| await expect(this.trigger).toBeEnabled(); | ||
| await this.trigger.click(); | ||
| await expect(this.menu).toBeVisible(); | ||
| } | ||
|
|
||
| async close() { | ||
| await this.page.keyboard.press('Escape'); | ||
| await expect(this.menu).not.toBeVisible(); | ||
| } | ||
|
|
||
| /** Open the menu and click one of its options. */ | ||
| async selectOption(optionTestId: string) { | ||
| await this.open(); | ||
| const option = this.option(optionTestId); | ||
| await expect(option).toBeVisible(); | ||
| await option.click(); | ||
| } | ||
|
|
||
| /** Labels of the options currently offered, in render order. */ | ||
| async optionLabels(): Promise<string[]> { | ||
| const labels = await this.menu.getByRole('menuitem').allInnerTexts(); | ||
| return labels.map(label => label.trim()); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required license header.
This TypeScript file starts with
exporton Line 1. Add the standard EUPL header before the first export.Proposed header
As per path instructions, TypeScript files must start with the standard EUPL license header.
📝 Committable suggestion
Source: Path instructions