Skip to content

Avoid obsolete filter syncing [2 days] #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mstahv wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Avoid obsolete filter syncing [2 days] #7135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a055bc0
Avoid obsolete filter syncing
mstahv Feb 21, 2025
29d5749
Avoid obsolete filter syncing
mstahv Feb 21, 2025
a2cd96f
Merge branch 'main' into bugix/avoid-many-obsolete-xhrs
vursen Jan 13, 2026
24a8a24
adding wait for text
mstahv Jan 13, 2026
44fc546
Merge branch 'bugix/avoid-many-obsolete-xhrs' of github.com:mstahv/fl…
mstahv Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...ion-tests/src/test/java/com/vaadin/flow/component/combobox/test/LazyComboBoxFilterIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@
*/
package com.vaadin.flow.component.combobox.test;

import org.junit.Assert;
import java.time.Duration;
import java.time.temporal.ChronoUnit;

import org.junit.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.support.ui.ExpectedConditions;
import org.openqa.selenium.support.ui.WebDriverWait;

import com.vaadin.flow.component.combobox.testbench.ComboBoxElement;
import com.vaadin.flow.testutil.TestPath;
Expand All @@ -35,7 +39,10 @@ public void lazyComboBoxFilterFirstQuery() {
comboBox.openPopup();

WebElement query = findElement(By.id("query"));
Assert.assertTrue(query.getText().contains("Filter: 1"));
Assert.assertTrue(query.getText().contains("Count: 10"));

WebDriverWait wait = new WebDriverWait(driver,
Duration.of(2, ChronoUnit.SECONDS));
wait.until(ExpectedConditions.textToBePresentInElement(query,
"Filter: 1 Count: 10"));
}
}
10 changes: 8 additions & 2 deletions .../vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBoxBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ public abstract class ComboBoxBase<TComponent extends ComboBoxBase<TComponent, T
HasValidationProperties, HasValidator<TValue>, HasPlaceholder {
private static final int DEFAULT_FILTER_TIMEOUT = 500;

private String lastKnownFilter;

/**
* Registration for custom value listeners that disallows entering custom
* values as soon as there are no more listeners for the custom value event
Expand Down Expand Up @@ -346,9 +348,8 @@ public void setAllowCustomValue(boolean allowCustomValue) {
*
* @return the filter string
*/
@Synchronize(property = "filter", value = "filter-changed")
protected String getFilter() {
return getElement().getProperty("filter");
return lastKnownFilter;
}

/**
Expand All @@ -359,7 +360,11 @@ protected String getFilter() {
* @param filter
* the String value to set
*/
@Deprecated
protected void setFilter(String filter) {
lastKnownFilter = filter;
// MT 20250-02-21 I assume client side never uses this, probably the
// whole method is obsolete
getElement().setProperty("filter", filter == null ? "" : filter);
}

Expand Down Expand Up @@ -1367,6 +1372,7 @@ private void confirmUpdate(int id) {
*/
@ClientCallable
private void setViewportRange(int start, int length, String filter) {
this.lastKnownFilter = filter;
dataController.setViewportRange(start, length, filter);
}

Expand Down