Fixed conformance_arena_constraints test failure with no NUMA hardware.#2042
Open
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Open
Fixed conformance_arena_constraints test failure with no NUMA hardware.#2042petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
petterreinholdtsen
force-pushed
the
test-numa-no-support
branch
from
5213a2e to
3df11e4
Compare
On a system without NUMA support, like GNU Hurd, the test would fail like this:
[doctest] doctest version is "2.4.12"
[doctest] run with "--help" for options
===============================================================================
test/conformance/conformance_arena_constraints.cpp:44:
TEST CASE: Test NUMA topology traversal correctness
test/conformance/conformance_arena_constraints.cpp:54: FATAL ERROR: REQUIRE( pos != numa_nodes_info.end() ) is NOT correct!
values: REQUIRE( {?} != {?} )
logged: Wrong, extra or repeated NUMA node index detected.
===============================================================================
[doctest] test cases: 5 | 4 passed | 1 failed | 0 skipped
[doctest] assertions: 27 | 26 passed | 1 failed |
[doctest] Status: FAILURE!
With the fix in place, the test succeed.
Fixes uxlfoundation#2039
petterreinholdtsen
force-pushed
the
test-numa-no-support
branch
from
3df11e4 to
ed99122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On a system without NUMA support, like GNU Hurd, the test would fail like this:
With the fix in place, the test succeed.
Fixes #2039
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility