Limit cleanup loop in test_tbb_fork to 5 iterations.#2041
Open
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Open
Limit cleanup loop in test_tbb_fork to 5 iterations.#2041petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
petterreinholdtsen
force-pushed
the
test-fork-no-endless-loop
branch
2 times, most recently
from
5de59db to
09026ab
Compare
There is no reason why the loop to clean up any pending signals should need more than two iterations to complete any SIGALRM and SIGCHLD remaining. Break the loop after 5 iterations and abort if it ever take this long, and sleep for one second every iteration to give even slow machines time to process the child. On GNU Hurd, the loop some times got stuck (around 1/3 of runs during my testing) in a endless stream of SIGCHLD signals. This code change ensure the test exits with an error instead of getting stuck forever.
petterreinholdtsen
force-pushed
the
test-fork-no-endless-loop
branch
from
09026ab to
f1a2853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no reason why the loop to clean up any pending signals should need more than two iterations to complete any SIGALRM and SIGCHLD remaining. Break the loop after 5 iterations and abort if it ever take this long, and sleep for one second every iteration to give even slow machines time to process the child.
On GNU Hurd, the loop some times got stuck (around 1/3 of runs during my testing) in a endless stream of SIGCHLD signals. This code change ensure the test exits with an error instead of getting stuck forever.
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility