Adjusted test_lightweight to avoid zero threads in test.#2033
Open
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Open
Adjusted test_lightweight to avoid zero threads in test.#2033petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
When the hardware only support one core, hardware_concurrency() return 1, which when deviced by 2 using integer division end up as 0, a useless number of threads. Instead, ensure it end up as 1, while the other return values still end up with a sensible number by changing (i/2) to ((i+1)/2). This fix is related to uxlfoundation#2027.
petterreinholdtsen
force-pushed
the
hardware-single-core
branch
from
e045591 to
8c968ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the hardware only support one core, hardware_concurrency() return 1, which when deviced by 2 using integer division end up as 0, a useless number of threads. Instead, ensure it end up as 1, while the other return values still end up with a sensible number by changing (i/2) to ((i+1)/2).
This fix is related to #2027.
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility